-
-
Notifications
You must be signed in to change notification settings - Fork 160
[RFC 0045] Deprecating unquoted URL syntax #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ba32469
A small RFC on deprecating URL syntax
7c6f434c cda4475
Convert alternatives to a list
7c6f434c e595a19
Add a mention of tooling in future work
7c6f434c 6b39d1b
A remark from @globin about one more problem with unquoted URLs
7c6f434c 268bb83
Grammar edit: comparison of URLs, paths and strings.
FRidh ca50c02
Style edit: possibility of future removal
FRidh e978077
0045: commit to using the tooling that now exists
7c6f434c e0b7512
Merge branch 'url-syntax-deprecation' of https://github.com/7c6f434c/…
7c6f434c 1773937
Update rfcs/0045-deprecate-url-syntax.md
7c6f434c cb1d204
Fix shepherd list
7c6f434c 2a99937
Update based on a discussion
7c6f434c 086786a
Explicitly make future removal conditional on editions; restrict the …
7c6f434c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| --- | ||
| feature: deprecate_url_syntax | ||
| start-date: 2019-04-28 | ||
| author: Michael Raskin | ||
| co-authors: | ||
| shepherd-leader: Eelco Dolstra | ||
| shepherd-team: Eelco Dolstra, zimbatm, Silvan Mosberger | ||
| related-issues: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure: the RFC template seems to imply this is for PRs implementing the RFC, not for the changes the RFC intends to undo. |
||
| --- | ||
|
|
||
| # Summary | ||
| [summary]: #summary | ||
|
|
||
| Discourage and eventually remove the use of unquoted URL syntax in Nix code and especially | ||
| Nixpkgs. | ||
|
|
||
| # Motivation | ||
| [motivation]: #motivation | ||
|
|
||
| The Nix language has a special syntax for URLs even though quoted strings can also be used to represent them. Unlike paths, URLs do not | ||
| have any special properties in the Nix expression language | ||
| that would make the difference useful. | ||
| Moreover, using | ||
| variable expansion in URLs requires some URLs to be quoted strings anyway. So | ||
| the most consistent approach is to always use quoted strings to represent URLs. | ||
| Additionally, a semicolon immediately after the URL can be mistaken for a part | ||
| of URL by language-agnostic tools such as terminal emulators. | ||
|
|
||
| Tools | ||
| targeting only Nixpkgs codebase can ignore URL syntax once Nixpkgs phases out | ||
| its use. | ||
|
|
||
| # Detailed design | ||
| [design]: #detailed-design | ||
|
|
||
| Add a note in the Nix manual that the special unquoted URL syntax is | ||
| discouraged and may be removed in a future edition of the Nix language. | ||
|
|
||
| Add a note in the Nixpkgs manual that the unquoted URL syntax should not be used anymore. | ||
|
|
||
| Convert all the unquoted URLs in the Nixpkgs codebase to quoted strings. | ||
|
|
||
| Add an ofBorg check that verifies that no new unquoted URLs have been added in | ||
| a PR. | ||
|
|
||
| # Drawbacks | ||
| [drawbacks]: #drawbacks | ||
|
|
||
| This is a minor cosmetic issue (and maybe a very minor readability issue) which | ||
| might not be worth making a specific decision. | ||
|
|
||
| # Alternatives | ||
| [alternatives]: #alternatives | ||
|
|
||
| * Do nothing; get PRs from time to time that make homepages uniformly quoted | ||
| strings or uniformly unquoted. | ||
|
|
||
| * Decide to use unquoted URLs for all URLs without special characters or | ||
| variable expansion. | ||
|
|
||
| # Unresolved questions | ||
| [unresolved]: #unresolved-questions | ||
|
|
||
| Currently none. | ||
|
|
||
| # Future work | ||
| [future]: #future-work | ||
|
|
||
| Currently none. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.