Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jan 12, 2023

Closes #453

@ghost
Copy link
Author

ghost commented Jan 12, 2023

My C++ is rusty so apologies if this is clumsily written.

@ghost ghost marked this pull request as draft February 13, 2023 11:59
@ghost
Copy link
Author

ghost commented Feb 13, 2023

I need to investigate this: #453 (comment)

@Mic92
Copy link
Member

Mic92 commented Feb 19, 2023

I remember we cannot do this: #453 (comment)

Binutils definitly does this optimization so if any of the nix store paths is used in other parts of the program than it messes up the binary. The only way this could work if all dyn entries would be checked before for potential collisions. If you want to go for this solution please open a new PR.

@Mic92 Mic92 closed this Feb 19, 2023
@ghost ghost deleted the issue453 branch February 23, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

patchelf --remove-rpath leaves the rpath string the file

1 participant