disallow aliases in the nixpkgs-tarball eval#597
Merged
cole-h merged 1 commit intoNixOS:releasedfrom Apr 22, 2022
Merged
Conversation
this allows ofborg to still check the aliases.nix file for errors unlike NixOS#594 which would have disabled aliases in outpaths.nix errors in the alias.nix file are caught by outpaths.nix eval so we can disable aliases here
13 tasks
Member
|
This doesn't appear to work. Compare the following running off of NixOS/nixpkgs#169822: and |
Member
|
Reverted in #598. This may be helpful -- the error during build comes after the following: So maybe the necessary change is above in the |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows ofborg to still check the aliases.nix file for errors
unlike #594 which would have
disabled aliases in outpaths.nix
errors in the alias.nix file are caught by outpaths.nix eval so we can
disable aliases here