check unfree packages for deprecated aliases#572
Closed
SuperSandro2000 wants to merge 1 commit intoNixOS:releasedfrom
SuperSandro2000:patch-1
Closed
check unfree packages for deprecated aliases#572SuperSandro2000 wants to merge 1 commit intoNixOS:releasedfrom SuperSandro2000:patch-1
SuperSandro2000 wants to merge 1 commit intoNixOS:releasedfrom
SuperSandro2000:patch-1
Conversation
Member
Author
|
@cole-h could you take a look at this? |
SuperSandro2000
commented
Jul 27, 2021
| String::from("--arg"), | ||
| String::from("config"), | ||
| String::from("{ allowAliases = false; }"), | ||
| String::from("{ allowAliases = false; allowUnfree = true; }"), |
Member
Author
There was a problem hiding this comment.
Suggested change
| String::from("{ allowAliases = false; allowUnfree = true; }"), | |
| String::from("{ allowAliases = false; allowBroken = true; allowUnfree = true; }"), |
Member
Author
|
@cole-h can you take a look at this PR? |
Closed
Member
|
#645 has been merged, which achieves a similar goal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably causing some regressions but after removing unfree aliases from https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/office/timedoctor/default.nix I think it is a good idea to do that.