eval-checker: use explicit 'nixpkgs' argument for release.nix expressions#189
Merged
grahamc merged 2 commits intoNixOS:releasedfrom Nov 22, 2018
Merged
eval-checker: use explicit 'nixpkgs' argument for release.nix expressions#189grahamc merged 2 commits intoNixOS:releasedfrom
grahamc merged 2 commits intoNixOS:releasedfrom
Conversation
9 tasks
…ions Using builtins.fetchGit is not allowed in restricted mode, but it's desirable for eg. the tarball build. So we avoid it for the evaluation checks. See NixOS/nixpkgs#43042
LnL7
force-pushed
the
nixpkgs-restricted-mode
branch
from
50d967b to
182f6c6
Compare
LnL7
force-pushed
the
nixpkgs-restricted-mode
branch
from
182f6c6 to
b8975bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstracting the evaluation of the release.nix expressions and attributes would be nicer, but this should fix the evaluation issues.
The test doesn't work yet, but I also had trouble reproducing the behaviour interactively.