Skip to content

Comments

pyqt5: 5.14.2 -> 5.15.1#99933

Closed
doronbehar wants to merge 2 commits intoNixOS:masterfrom
doronbehar:pkg/pyqt5/update
Closed

pyqt5: 5.14.2 -> 5.15.1#99933
doronbehar wants to merge 2 commits intoNixOS:masterfrom
doronbehar:pkg/pyqt5/update

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 7, 2020

Update pyqt and sip.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar changed the title ###### Motivation for this change pyqt5: 5.14.2 -> 5.15.1 Oct 7, 2020
@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 7, 2020
@doronbehar
Copy link
Contributor Author

doronbehar commented Oct 7, 2020

This does not solve #99937

This was referenced Oct 7, 2020
Closed
Closed
@ofborg ofborg bot requested a review from svanderburg October 7, 2020 09:56
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 7, 2020
@jorsn
Copy link
Member

jorsn commented Oct 7, 2020

This does not solve #99937

It cannot, because qt5 is overridden in pythonInterpreters.

@doronbehar doronbehar closed this Oct 8, 2020
@doronbehar doronbehar mentioned this pull request Oct 8, 2020
Closed
10 tasks
@doronbehar doronbehar deleted the pkg/pyqt5/update branch October 8, 2020 20:26
@doronbehar
Copy link
Contributor Author

doronbehar commented Oct 8, 2020

Done in #99956 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doronbehar @jorsn