Skip to content

spotify-unwrapped: 1.1.26.501.gbe11e53b-15 -> 1.1.42.622.gbd112320-37#99924

Merged
timokau merged 3 commits intoNixOS:masterfrom
samuela:upkeep-bot/spotify-unwrapped-1.1.42.622.gbd112320-37-1602046083
Oct 12, 2020
Merged

spotify-unwrapped: 1.1.26.501.gbe11e53b-15 -> 1.1.42.622.gbd112320-37#99924
timokau merged 3 commits intoNixOS:masterfrom
samuela:upkeep-bot/spotify-unwrapped-1.1.42.622.gbd112320-37-1602046083

Conversation

@samuela
Copy link
Member

@samuela samuela commented Oct 7, 2020

Motivation for this change

Upgrades spotify-unwrapped from 1.1.26.501.gbe11e53b-15 to 1.1.42.622.gbd112320-37

This PR was automatically generated by nixpkgs-upkeep.

  • CI workflow that created this PR.
  • Internal tag: 08bf683e76229c9bff6cc4c2764e4d49.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 7, 2020
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs manual intervention

$ spotify
/nix/store/7q5jvc61dq5di8li9wf7wf7ly4pwjf54-spotify-1.1.42.622.gbd112320-37/bin/.spotify-wrapped: error while loading shared libraries: libdrm.so.2: cannot open shared object file: No such file or directory

@samuela
Copy link
Member Author

samuela commented Oct 8, 2020

@timokau Ok, noob question... I have this branch checked out but nix-shell is not doing what I'd expect:

nixpkgs on  upkeep-bot/spotify-unwrapped-1.1.42.622.gbd112320-37-1602046083 [?] took 27s 
> nix-shell /home/skainswo/dev/nixpkgs -p spotify --pure         

gives me a shell with the old spotify version that still works. What's the right way to drop into a nix-shell with the development version?

@Ma27
Copy link
Member

Ma27 commented Oct 9, 2020

@samuela nix-shell -p always uses the nixpkgs from NIX_PATH. To open a shell with a package from your branch you have to do sth. like this:

$ nix-shell -I nixpkgs=/home/skainswo/dev/nixpkgs -p spotify

@timokau
Copy link
Member

timokau commented Oct 9, 2020

Alternatives are nix run -f. spotify (if you are using the experimental nix command) or nix-build -A spotify; result/bin/spotify.

@samuela
Copy link
Member Author

samuela commented Oct 9, 2020

Thanks @Ma27! That's a very confusing interface, but it does the trick.

I fixed the libdrm issue in 03ccf40, but now there's a new one:

[nix-shell:~/dev/nixpkgs]$ spotify 
/nix/store/lrqra654hqrk7hdghlhpvzkgnxv0mx1b-spotify-1.1.42.622.gbd112320-37/bin/.spotify-wrapped: error while loading shared libraries: libgbm.so.1: cannot open shared object file: No such file or directory

but unfortunately I wasn't able to find libgbm: https://search.nixos.org/packages?show=libdrm&query=libgbm&from=0&size=30&sort=relevance&channel=unstable.

@timokau
Copy link
Member

timokau commented Oct 9, 2020

If you're looking for a specific file, you can use nix-locate. Unfortunately it can't find libgbm.so.1 either, so its probably not packaged. Most likely its https://github.com/libgm/libgm, though it seems a bit odd that spotify introduces a new dependency on a seemingly unmaintained library in "alpha" status.

@timokau
Copy link
Member

timokau commented Oct 9, 2020

Actually never mind. I mistyped the name. libgbm.so.1 is available in the mesa package.

@samuela
Copy link
Member Author

samuela commented Oct 9, 2020

Ok, I added the mesa dependency in e771518 and spotify builds and runs for me now.

If you're looking for a specific file, you can use nix-locate. Unfortunately it can't find libgbm.so.1 either, so its probably not packaged. Most likely its https://github.com/libgm/libgm, though it seems a bit odd that spotify introduces a new dependency on a seemingly unmaintained library in "alpha" status.

I wasn't able to get this to work:

nixpkgs on  upkeep-bot/spotify-unwrapped-1.1.42.622.gbd112320-37-1602046083 [?] took 2m10s 
> nix-locate 'libgbm'

nixpkgs on  upkeep-bot/spotify-unwrapped-1.1.42.622.gbd112320-37-1602046083 [?] 
> 

Am I using nix-locate correctly?

@samuela
Copy link
Member Author

samuela commented Oct 9, 2020

Actually there are still some interesting warnings:

/nix/store/4s9aim1fk1s3npkzfygs7jlby6mg4126-spotify-1.1.42.622.gbd112320-37/bin/.spotify-wrapped: /nix/store/k1bskbhj1843vnrz1sbnzxrb32fp2irz-curl-7.72.0/lib/libcurl-gnutls.so.4: no version information available (required by /nix/store/4s9aim1fk1s3npkzfygs7jlby6mg4126-spotify-1.1.42.622.gbd112320-37/bin/.spotify-wrapped)
/nix/store/i99627w01d7bzp4ij4bqg8m22pwaa760-spotify-unwrapped-1.1.42.622.gbd112320-37/share/spotify/.spotify-wrapped: /nix/store/k1bskbhj1843vnrz1sbnzxrb32fp2irz-curl-7.72.0/lib/libcurl-gnutls.so.4: no version information available (required by /nix/store/i99627w01d7bzp4ij4bqg8m22pwaa760-spotify-unwrapped-1.1.42.622.gbd112320-37/share/spotify/.spotify-wrapped)
/nix/store/i99627w01d7bzp4ij4bqg8m22pwaa760-spotify-unwrapped-1.1.42.622.gbd112320-37/share/spotify/.spotify-wrapped: /nix/store/k1bskbhj1843vnrz1sbnzxrb32fp2irz-curl-7.72.0/lib/libcurl-gnutls.so.4: no version information available (required by /nix/store/i99627w01d7bzp4ij4bqg8m22pwaa760-spotify-unwrapped-1.1.42.622.gbd112320-37/share/spotify/.spotify-wrapped)
/proc/self/exe: /nix/store/k1bskbhj1843vnrz1sbnzxrb32fp2irz-curl-7.72.0/lib/libcurl-gnutls.so.4: no version information available (required by /proc/self/exe)

EDIT: it seems that the current version has the same warnings.

@samuela
Copy link
Member Author

samuela commented Oct 9, 2020

It plays songs and everything else just fine but "Recently Played", "Liked Songs", and "Albums" are just empty... I think that may be Spotify's fault though...

@samuela
Copy link
Member Author

samuela commented Oct 9, 2020

nvm it all works just fine as long as I quit all the other spotify processes first... software is weird

@timokau
Copy link
Member

timokau commented Oct 11, 2020

Am I using nix-locate correctly?

nix-locate searches for filenames, so you have to type the exact name of the file you're searching for (including the extension).

@timokau
Copy link
Member

timokau commented Oct 11, 2020

Thanks for working on this! There's an ofBorg error, unfortunately I don't have time to look into it right now.

@samuela
Copy link
Member Author

samuela commented Oct 11, 2020

The error is apparently

pkgs/servers/mediatomb/default.nix:1:1 called without required argument 'spidermonkey'

but I don't think this has anything to do with spotify?

@timokau
Copy link
Member

timokau commented Oct 12, 2020

Right, unrelated (#100089, #100095).

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from timokau October 12, 2020 08:57
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'll take the liberty to squash&merge to keep a working commit history.

@timokau timokau merged commit 3d99082 into NixOS:master Oct 12, 2020
@samuela samuela deleted the upkeep-bot/spotify-unwrapped-1.1.42.622.gbd112320-37-1602046083 branch October 12, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants