pythonPackages.python-openems: init at unstable-2020-02-15#99880
Merged
jonringer merged 1 commit intoNixOS:masterfrom Oct 17, 2020
Merged
pythonPackages.python-openems: init at unstable-2020-02-15#99880jonringer merged 1 commit intoNixOS:masterfrom
jonringer merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
the
6.topic: python
jonringer
reviewed
Oct 6, 2020
Comment on lines
26
to
29
Contributor
There was a problem hiding this comment.
boost is usually linked against, and should go into buildInputs
Suggested change
| nativeBuildInputs = [ | |
| cython | |
| boost | |
| ]; | |
| nativeBuildInputs = [ | |
| cython | |
| ]; | |
| buildInputs = [ | |
| boost | |
| ]; |
Contributor
There was a problem hiding this comment.
although this is refering to the python package, not actually sure about this case
cc @FRidh
ofborg
bot
added
8.has: package (new)
10 tasks
Contributor
|
Just want to say thanks for doing this packaging work! |
Contributor
Author
|
I'm glad it's useful! |
jonringer
reviewed
Oct 13, 2020
matthuszagh
force-pushed
the
python-openems
branch
from
1a7f033 to
848d4fc
Compare
Contributor
Author
|
@jonringer added imports check. |
jonringer
reviewed
Oct 17, 2020
matthuszagh
force-pushed
the
python-openems
branch
from
848d4fc to
fd6fd28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds python bindings for openems. Last piece of this PR. @jonringer.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)