gitit: Remove staticDir and templatesDir

[matthiasbeyer]

as these cannot be overridden if specified here.

---

My attempt to fix #9863. I don't know whether this is a step in the right direction or not.

Ping to all haskellers I can find, because I have no clue who is responsible for the service file
CC: @gebner @gridaphobe @jb55 @khumba @psibi @ttuegel

[khumba]

(Disclaimer, I don't know about gitit.) I see that there are config options defined for those, and that the options are used in the generated config file and the systemd service, but strangely, they're hard-coded. It conflicts if you try to set it without your patch, right? If so, looks fine to me, but I'd recommend setting `default` attributes for `staticDir` and `templatesDir` to what they were previously fixed to.

[matthiasbeyer]

@khumba Good idea!

[edwtjo]

As the author of the module I would like to have these options available, which I'm using in a private module. For nixpkgs, it was commit 99750d8 that essentially made them useless.

@khumba that would require evaluation of the haskellPackages set.

I would recommend setting them null by default and changing the type to nullOr. Also checking for null in the config inclusion.

[matthiasbeyer]

@edwtjo Sorry I do not understand your comment. Shall I set these options to null by default?

What's funny: As far as I can see, the path for the static and template dir is hard coded to the store itself in the service definition. And there is no way to override a service, is there? So this package is rather useless as-is.

[edwtjo]

@matthiasbeyer yes that is what I meant, but also modify configFile. Anyway these alterations will just be ugly hacks, let's avoid those on second thought.

And there is no way to override a service, is there? So this package is rather useless as-is.

I'm not exactly sure what you mean but no 99750d8 was not a very good idea. So since @edolstra don't want the computational and storage overhead with the module; The only correct way to move forward is to remove gitit.nix from the module list, reverting 99750d8 and instead requiring it to be manually added into your configuration.nix. Which was done in 122d5e4 and aeba3ea