Skip to content

pythonPackages.arviz: 0.7.0 -> 0.10.0, fixing tests#99500

Merged
jonringer merged 1 commit intoNixOS:masterfrom
risicle:ris-arviz-0.10.0
Oct 11, 2020
Merged

pythonPackages.arviz: 0.7.0 -> 0.10.0, fixing tests#99500
jonringer merged 1 commit intoNixOS:masterfrom
risicle:ris-arviz-0.10.0

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 3, 2020

Motivation for this change

ZHF: #97479

This doesn't fix:

  • reverse dependency pymc3, which now shows its own build failure. Perhaps I will get onto that next.
  • building on darwin, which is blocked by broken dependency tensorflow there. I'm not touching that one with a bargepole.

There are also some existing suggestions in comments in this package of how more of the tests could be enabled, but I haven't done anything about that. Some tests it seems require pymc3, which, now, itself depends on arviz, so that's unlikely to happen unless we move some of the tests to a passthru.tests, which could depend on both by being outside the dependency cycle (?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented Oct 3, 2020

@ofborg build python37Packages.arviz python38Packages.arviz

@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 3, 2020
@ofborg ofborg bot requested a review from OmnipotentEntity October 3, 2020 19:38
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 3, 2020
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/99500
1 package failed to build:
python37Packages.pymc3

1 package built:
python37Packages.arviz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants