pythonPackages.arviz: 0.7.0 -> 0.10.0, fixing tests#99500
Merged
jonringer merged 1 commit intoNixOS:masterfrom Oct 11, 2020
Merged
pythonPackages.arviz: 0.7.0 -> 0.10.0, fixing tests#99500jonringer merged 1 commit intoNixOS:masterfrom
jonringer merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
Author
|
@ofborg build python37Packages.arviz python38Packages.arviz |
This was referenced Oct 4, 2020
jonringer
approved these changes
Oct 11, 2020
Contributor
jonringer
left a comment
There was a problem hiding this comment.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/99500
1 package failed to build:
python37Packages.pymc3
1 package built:
python37Packages.arviz
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF: #97479
This doesn't fix:
pymc3, which now shows its own build failure. Perhaps I will get onto that next.tensorflowthere. I'm not touching that one with a bargepole.There are also some existing suggestions in comments in this package of how more of the tests could be enabled, but I haven't done anything about that. Some tests it seems require
pymc3, which, now, itself depends onarviz, so that's unlikely to happen unless we move some of the tests to apassthru.tests, which could depend on both by being outside the dependency cycle (?)Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)