Skip to content

Comments

kodi: remove jre override, use jre_headless#99255

Merged
FRidh merged 1 commit intoNixOS:masterfrom
georgewhewell:kodi-jre-headless
Oct 25, 2020
Merged

kodi: remove jre override, use jre_headless#99255
FRidh merged 1 commit intoNixOS:masterfrom
georgewhewell:kodi-jre-headless

Conversation

@georgewhewell
Copy link
Contributor

Since #89731 is merged we can remove jre override on kodi builds.

Also, we can use headless build which reduce dependency tree a bit, useful for ARM platforms

tested on x86

Motivation for this change

reduce dependency tree on ARM

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 1, 2020
@andir
Copy link
Member

andir commented Oct 1, 2020

This is also an update from jre8 to 14. Is that intended? Any downsides with that? I can only test if it compiles but thought it might be worth mentioning.

@aanderse
Copy link
Member

aanderse commented Oct 1, 2020

I don't think java is used for much in kodi. I think it is just bluray support maybe... a quick search says:

https://forums.gentoo.org/viewtopic-t-1089736-start-0.html

Kodi only uses Java at build time to generate some files. It does not use it at runtime. I understand that, but something else might use it if it detects it, browsers etc.

I'm not too concerned about the bump 🤷‍♂️

Maybe @peterhoeg would like to comment.

@georgewhewell
Copy link
Contributor Author

This is also an update from jre8 to 14. Is that intended? Any downsides with that? I can only test if it compiles but thought it might be worth mentioning.

since it compiles + runs it seems happy with 14 (and as @aanderse say its just build-time dependency)

@peterhoeg
Copy link
Member

@georgewhewell - ofborg doesn't evaluate kodi on arm64 but since that's what you are specifically targeting with this PR, is there any chance you could massage that into happening?

@lheckemann
Copy link
Member

@peterhoeg this is an error happening on ofborg aarch64 evals generally recently, not related to these changes.

@FRidh FRidh merged commit 53c52f1 into NixOS:master Oct 25, 2020
@georgewhewell georgewhewell deleted the kodi-jre-headless branch October 25, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants