kodi: remove jre override, use jre_headless#99255
Conversation
|
This is also an update from jre8 to 14. Is that intended? Any downsides with that? I can only test if it compiles but thought it might be worth mentioning. |
|
I don't think https://forums.gentoo.org/viewtopic-t-1089736-start-0.html
I'm not too concerned about the bump 🤷♂️ Maybe @peterhoeg would like to comment. |
since it compiles + runs it seems happy with 14 (and as @aanderse say its just build-time dependency) |
|
@georgewhewell - ofborg doesn't evaluate kodi on arm64 but since that's what you are specifically targeting with this PR, is there any chance you could massage that into happening? |
|
@peterhoeg this is an error happening on ofborg aarch64 evals generally recently, not related to these changes. |
Since #89731 is merged we can remove jre override on kodi builds.
Also, we can use headless build which reduce dependency tree a bit, useful for ARM platforms
tested on x86
Motivation for this change
reduce dependency tree on ARM
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)