buildRustCrate: fix target config environment variables on 32-bit ARM#99066
buildRustCrate: fix target config environment variables on 32-bit ARM#99066Ericson2314 merged 2 commits intoNixOS:masterfrom
Conversation
|
This is looking good! Can you also add a minimal cross compilation test for this? I'd hate to have this fail silently due to other changes/refactorings. It is a corner-case after all. |
|
@GrahamcOfBorg build buildRustCrateTests |
|
I made @ofborg build buildRustCrateTests pkgsCross.armv7l-hf-multiplatform.buildRustCrateTests |
|
Happy to merge once tests pass! (Or without if they take forever because things are not yet cached.) |
|
The test failure looks like a transient ofborg issue. I'll try to run it again. @ofborg build buildRustCrateTests pkgsCross.armv7l-hf-multiplatform.buildRustCrateTests |
|
@ofborg build pkgsCross.armv7l-hf-multiplatform.buildRustCrateTests |
|
@ofborg build buildRustCrateTests |
|
OK screw it, merging. |
Motivation for this change
Followup to #99050, fixing issues I found while trying to cross-compile some other packages with
crate2nix.Because
TARGETwasn't set correctly, theautocfgcrate was unable to run its compile tests, and downstream crates didn't get features enabled correctly.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @Ericson2314 @danieldk @kolloch @andir @symphorien