Skip to content

nixos/tor: allow onion only clients#98801

Closed
d-xo wants to merge 1 commit intoNixOS:masterfrom
d-xo:torOnionOnly
Closed

nixos/tor: allow onion only clients#98801
d-xo wants to merge 1 commit intoNixOS:masterfrom
d-xo:torOnionOnly

Conversation

@d-xo
Copy link
Contributor

@d-xo d-xo commented Sep 25, 2020

Motivation for this change

This allows users to ensure that their tor client will only ever connect to onion services.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

jonringer commented Sep 25, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 26, 2020
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@taku0
Copy link
Contributor

taku0 commented Jan 31, 2021

Code-wise LGTM. Please rebase on master.

@stale
Copy link

stale bot commented Jul 30, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 30, 2021
@wegank wegank marked this pull request as draft March 20, 2024 15:36
@philiptaron
Copy link
Contributor

philiptaron commented Jul 15, 2025 •
edited
Loading

0ccdd6f (part of #97740) added this option under services.tor.client.socksListenAddress.

@d-xo d-xo deleted the torOnionOnly branch July 16, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@d-xo @jonringer @taku0 @philiptaron @SuperSandro2000