Skip to content

nixos/datadog: Don't recommend dd_url for sites, add proper option#98793

Merged
flokli merged 1 commit intoNixOS:masterfrom
flokli:dd-site
Sep 26, 2020
Merged

nixos/datadog: Don't recommend dd_url for sites, add proper option#98793
flokli merged 1 commit intoNixOS:masterfrom
flokli:dd-site

Conversation

@flokli
Copy link
Copy Markdown
Member

@flokli flokli commented Sep 25, 2020

Turns out, dd_url should only be used in proxy scenarios, not to point
datadog to their EU endpoint - site should be used for that.

The dd_url setting doesn't affect APM, Logs or Live Process intake
which have their own "*_dd_url" settings.

Motivation for this change

Using dd_url from #97775 only worked for the main agent, but not the Process Agent, for example.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
nixos/datadog: Don't recommend dd_url for sites, add proper option
8d52cf5 
Turns out, `dd_url` should only be used in proxy scenarios, not to point
datadog to their EU endpoint - `site` should be used for that.

The `dd_url` setting doesn't affect APM, Logs or Live Process intake
which have their own "*_dd_url" settings.
@flokli flokli requested review from arianvp, rvl and zimbatm September 25, 2020 20:34
@jonringer
Copy link
Copy Markdown
Contributor

jonringer commented Sep 25, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 26, 2020
@flokli flokli merged commit ecad934 into NixOS:master Sep 26, 2020
@flokli flokli deleted the dd-site branch September 26, 2020 10:27
@flokli
Copy link
Copy Markdown
Member Author

flokli commented Sep 26, 2020

Backported to 20.09 as 17ecf6e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimbatm zimbatm zimbatm approved these changes

@arianvp arianvp Awaiting requested review from arianvp

@rvl rvl Awaiting requested review from rvl

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flokli @jonringer @zimbatm