Skip to content

Comments

*: use latest jdk#98314

Merged
gebner merged 11 commits intoNixOS:masterfrom
gebner:upgradejava
Sep 20, 2020
Merged

*: use latest jdk#98314
gebner merged 11 commits intoNixOS:masterfrom
gebner:upgradejava

Conversation

@gebner
Copy link
Member

@gebner gebner commented Sep 20, 2020

Motivation for this change

Continuation of #89731, upgrade some (tested) packages from jdk11 and jdk8 to jdk14.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from jlesquembre, rycee and vbgl September 20, 2020 09:56
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 20, 2020
rycee
rycee approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@rycee rycee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for gpsprune and josm

@gebner gebner merged commit a2bd21f into NixOS:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rycee rycee rycee approved these changes

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

@vbgl vbgl Awaiting requested review from vbgl

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gebner @rycee