Skip to content

Comments

[20.09] unnethack: 5.2.0 -> 5.3.2, fix build#98254

Merged
AndersonTorres merged 1 commit intoNixOS:release-20.09from
Mathnerd314:20.09-unnethack
Sep 19, 2020
Merged

[20.09] unnethack: 5.2.0 -> 5.3.2, fix build#98254
AndersonTorres merged 1 commit intoNixOS:release-20.09from
Mathnerd314:20.09-unnethack

Conversation

@Mathnerd314
Copy link
Contributor

@Mathnerd314 Mathnerd314 commented Sep 19, 2020

Motivation for this change

Backport of #97595.

ZHF: #97479

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mathnerd314 @jonringer
unnethack: 5.2.0 -> 5.3.2 (NixOS#97595)
d6d7be3 
Co-authored-by: Jon <jonringer@users.noreply.github.com>
(cherry picked from commit 47ba35d)
@Mathnerd314 Mathnerd314 changed the base branch from nixos-20.09 to release-20.09 September 19, 2020 01:58
@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: TeX Issues regarding texlive and TeX in general 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 19, 2020
@ofborg ofborg bot requested a review from abbradar September 19, 2020 02:16
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 19, 2020
@AndersonTorres AndersonTorres merged commit bea7aa2 into NixOS:release-20.09 Sep 19, 2020
@Mathnerd314 Mathnerd314 deleted the 20.09-unnethack branch September 19, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: TeX Issues regarding texlive and TeX in general 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mathnerd314 @AndersonTorres