Closed
Conversation
Member
|
FreeCAD is also broken for this reason. It currently uses |
e1e8dd8 to
4e8ac88
Compare
Member
Contributor
Author
|
Fixed (a4e50bb). |
Member
Member
|
@FRidh The override doesn't seem to work for me at all (this is on current master): |
Member
|
Yes, I did not test it correctly. See the discussion in #98197. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Essentially a partial revert of the changes made #97586, which fixes Python QT packages that aren't wrapped well and leaves the version configurability for those that are. This should sort out the likes of #98067 and #98069.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)