Skip to content

x265: 3.2 -> 3.4#98091

Merged
FRidh merged 1 commit intoNixOS:stagingfrom
titouanco:x265
Oct 6, 2020
Merged

x265: 3.2 -> 3.4#98091
FRidh merged 1 commit intoNixOS:stagingfrom
titouanco:x265

Conversation

@titouanco
Copy link
Contributor

  • Change version from 3.2 to 3.4
  • Use fetchFromBitbucket to fetch the archive from multicoreware/x265_git instead of the videolan server (doesn't have the latest version)
  • Remove the ARM patch, doesn't work anymore but doesn't seems necessary since this commit
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from codyopel September 16, 2020 10:57
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Sep 16, 2020
@ajs124 ajs124 mentioned this pull request Sep 16, 2020
10 tasks
@FRidh FRidh changed the base branch from master to staging October 6, 2020 08:17
@FRidh FRidh merged commit c1a0aa7 into NixOS:staging Oct 6, 2020
@thefloweringash thefloweringash mentioned this pull request Oct 17, 2020
10 tasks
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments