Skip to content

Comments

inkcut: fix by using the standard qt5 version#97971

Closed
raboof wants to merge 1 commit intoNixOS:masterfrom
raboof:inkcut-fix-qt5-version
Closed

inkcut: fix by using the standard qt5 version#97971
raboof wants to merge 1 commit intoNixOS:masterfrom
raboof:inkcut-fix-qt5-version

Conversation

@raboof
Copy link
Member

@raboof raboof commented Sep 14, 2020

This broke with c1a0dfa

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof mentioned this pull request Sep 14, 2020
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 14, 2020
@raboof raboof force-pushed the inkcut-fix-qt5-version branch from fc8999e to 69403aa Compare September 14, 2020 11:41
@raboof
Copy link
Member Author

raboof commented Sep 17, 2020

this might no longer be relevant

@raboof raboof closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@raboof