Skip to content

[20.09] python2Packages.flask-api: remove#97878

Closed
freezeboy wants to merge 1 commit intoNixOS:release-20.09from
freezeboy:backport-flask-api
Closed

[20.09] python2Packages.flask-api: remove#97878
freezeboy wants to merge 1 commit intoNixOS:release-20.09from
freezeboy:backport-flask-api

Conversation

@freezeboy
Copy link
Copy Markdown
Contributor

@freezeboy freezeboy commented Sep 13, 2020

(cherry picked from commit bd6dbf1)

Motivation for this change

Initial PR: #97766

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
python2Packages.flask-api: remove
626cd24 
(cherry picked from commit bd6dbf1)
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 13, 2020
jonringer
jonringer reviewed Sep 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit that you cherry-picked doesn't exist in the upstream repo. Please pick the commit from the master branch

@freezeboy
Copy link
Copy Markdown
Contributor Author

freezeboy commented Sep 13, 2020

in fact this backport has already been merged, so closing

@freezeboy freezeboy closed this Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

1 more reviewer

@jonringer jonringer jonringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@freezeboy @jonringer