top-level: fix nix-shell eval w/nixUnstable#97807
Merged
Ma27 merged 1 commit intoNixOS:masterfrom Sep 14, 2020
Merged
Conversation
For a full description of the underlying issue please read NixOS/nix#4003
Member
Author
|
Note: IMHO we should backport this to 20.09 and 20.03 to allow users of |
Member
Author
10 tasks
10 tasks
Contributor
|
I just upgraded to nix 2.4 stable and found this issue when trying to reproduce a nixpkgs 20.03 build (from before the backport patch). It is quite unfortunate that with nix >= 2.4, you cannot reproduce old builds at all now, because they don't evaluate, breaking the reproducibility story. Is there something that could be done in |
Member
|
I'm trying to fix that over here but that isn't as straight forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
For a full description of the underlying issue please read
NixOS/nix#4003
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)