Skip to content

python2Packages.cx_Freeze: remove#97763

Merged
teto merged 1 commit intoNixOS:masterfrom
freezeboy:disable-py2-cx_Freeze
Sep 12, 2020
Merged

python2Packages.cx_Freeze: remove#97763
teto merged 1 commit intoNixOS:masterfrom
freezeboy:disable-py2-cx_Freeze

Conversation

@freezeboy
Copy link
Copy Markdown
Contributor

@freezeboy freezeboy commented Sep 11, 2020 •
edited
Loading

Motivation for this change

package don't support python 2
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 11, 2020
drewrisinger
drewrisinger reviewed Sep 11, 2020
View reviewed changes
@freezeboy freezeboy force-pushed the disable-py2-cx_Freeze branch from 2031bcb to e3912be Compare September 11, 2020 14:05
drewrisinger
drewrisinger approved these changes Sep 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 package removed:
python2.7-cx_Freeze (†6.2)

@drewrisinger
Copy link
Copy Markdown
Contributor

drewrisinger commented Sep 11, 2020

For future reference, PR titles should start with the top-level attribute of how they're referenced. For this, e.g. python27Packages.cx_freeze: disable

@freezeboy freezeboy changed the title cx_Freeze: disable python2.7 python2Packages.cx_Freeze: remove Sep 11, 2020
@teto teto merged commit 1be0767 into NixOS:master Sep 12, 2020
@teto
Copy link
Copy Markdown
Member

teto commented Sep 12, 2020

@freezeboy thanks for the help on ZHF. You had to change the commit message but I could do it from GH's UI so that's fine.

@freezeboy freezeboy mentioned this pull request Sep 13, 2020
Merged
10 tasks
@freezeboy freezeboy deleted the disable-py2-cx_Freeze branch September 13, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

1 more reviewer

@drewrisinger drewrisinger drewrisinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@freezeboy @drewrisinger @teto