Skip to content

gnomeExtensions.dash-to-panel: 38 -> 39#97650

Closed
felschr wants to merge 1 commit intoNixOS:masterfrom
felschr:patch-5
Closed

gnomeExtensions.dash-to-panel: 38 -> 39#97650
felschr wants to merge 1 commit intoNixOS:masterfrom
felschr:patch-5

Conversation

@felschr
Copy link
Copy Markdown
Member

@felschr felschr commented Sep 10, 2020 •
edited
Loading

Motivation for this change

Compatibility issues with gnome-shell 3.36.5 have been fixed:
https://github.com/home-sweet-gnome/dash-to-panel/releases/tag/v39

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 10, 2020
@felschr felschr changed the base branch from nixos-unstable to master September 14, 2020 10:58
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 14, 2020
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Sep 16, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/302

@doronbehar
Copy link
Copy Markdown
Contributor

doronbehar commented Sep 16, 2020

Superseded by #97840.

@doronbehar doronbehar closed this Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felschr @nixos-discourse @doronbehar