clean: Accept hardcoded /tmp

[Lucus16]

Motivation for this change

This fixes a build failure caused by a /tmp path being detected as impure. Tested the compiler on some of my homework.

ZHF: #97479

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[jonringer]

I think the more proper fix would be to patch usages of /tmp to point to $TMPDIR

[Lucus16]

Since some usages are in const strings in C files that seems like too much work.

…

On Wed, Sep 9, 2020, 19:42 Jon ***@***.***> wrote: I think the more proper fix would be to patch usages of /tmp to point to $TMPDIR — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#97519 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAS7M4XPARCS3Y7FB4P6VO3SE65A5ANCNFSM4RBUQYEQ> .

[vcunat]

I don't think we'll need this. Those strictness checks were reverted (ATM on master and staging-20.09), because such unintended cases were breaking more stuff in practice than anticipated. A new version is planned in PR #97597 but it should be less strict and not give this problem.

[Lucus16]

Yes, this became irrelevant, closing.