Merged
Conversation
- EXIV2_BUILD_PO has been replaced by EXIV2_ENABLE_NLS Exiv2/exiv2@076585d Confusingly, the former still appears in the flag summary. - Remove enableParallelBuilding since it is on by default with CMake - Reorder the expression - Apply upstream GNUInstallDirs patch - Build stuff in build phase, not in install phase - Add maintainers field (empty at the moment)
da65be9 to
3dc2c52
Compare
worldofpeace
approved these changes
Sep 8, 2020
Member
|
It looks like this didn't quite work as intended, it broke the digikam build: Apparently |
10 tasks
This was referenced Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Exiv2/exiv2@076585d
Confusingly, the former still appears in the flag summary.
cc @paperdigits
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)