Show sub options of freeform types#97042
Merged
infinisil merged 2 commits intoNixOS:masterfrom Sep 7, 2020
Merged
Conversation
Previously if you set the freeform type to e.g. attrsOf (submodule ..), those submodule options wouldn't be shown in the manual.
roberth
reviewed
Sep 3, 2020
Member
roberth
left a comment
There was a problem hiding this comment.
Suggestion and it would be nice to have a simple test case for this.
Contributor
|
Just checked out the change on my code and seems to work well. Thanks @infinisil Only nitpick is the following: Is there a way to stop this top level package appearing in the documentation? |
Member
Author
|
@roberth Added a test for that @alexarice Not possible as of now, but I'll keep this use case in mind if I happen to touch the relevant code for it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation for this change
Previously if you set the freeform type (as introduced in #82743) to e.g.
attrsOf (submodule ..), those submodule options wouldn't be shown in the manual.Originally this problem was brought to my attention by @alexarice
With an option declaration like
The manual now correctly shows
Ping @roberth
Things done
freeformType = attrsOf (attrsOf (submodule { freeformType = attrsOf ...work