Skip to content

Comments

.github/workflows/pending-set.yml: failed -> pending#96707

Merged
cole-h merged 1 commit intoNixOS:masterfrom
zowoq:ofborg-pending
Jan 30, 2021
Merged

.github/workflows/pending-set.yml: failed -> pending#96707
cole-h merged 1 commit intoNixOS:masterfrom
zowoq:ofborg-pending

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 30, 2020

Blocked by NixOS/ofborg#527, it needs to be merged and deployed first.

Closes #96695

@zowoq zowoq added 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 9.needs: upstream fix This PR needs upstream to change something labels Aug 30, 2020
Copy link
Contributor

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing task is pretty jarring when you first see it, but do pending tasks block merge? I think it's a great change if so but I don't have the commit bit.

@zowoq
Copy link
Contributor Author

zowoq commented Aug 30, 2020

do pending tasks block merge

No, but the reason it is set to failed is:

#96056 (comment)
currently ofborg only sends check_suite at the end of eval so a PR that fails early will stay as pending

@ofborg ofborg bot added 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 31, 2020
@worldofpeace
Copy link
Contributor

Is this something we can fix now that @grahamc is back?

@zowoq
Copy link
Contributor Author

zowoq commented Dec 6, 2020

I'll reopen if NixOS/ofborg#527 progresses.

@zowoq zowoq closed this Dec 6, 2020
@zowoq zowoq reopened this Jan 29, 2021
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be redeploying borg when I'm available in about 2-3 hours. After that succeeds, I'll merge this. Thanks!

@cole-h cole-h marked this pull request as ready for review January 30, 2021 03:40
@cole-h cole-h requested a review from Mic92 as a code owner January 30, 2021 03:40
@cole-h cole-h merged commit ac98f99 into NixOS:master Jan 30, 2021
@cole-h cole-h removed 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 9.needs: upstream fix This PR needs upstream to change something labels Jan 30, 2021
@zowoq zowoq deleted the ofborg-pending branch January 30, 2021 06:24
@cole-h
Copy link
Member

cole-h commented Feb 10, 2021

"Backported" to release-20.09 in 6fbc72a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wait for ofborg check sets a failed status when pending

4 participants