Revert "systemd: build with cryptsetup and cryptsetup-generators"#96575
Closed
jpdoyle wants to merge 1 commit intoNixOS:masterfrom
Closed
Revert "systemd: build with cryptsetup and cryptsetup-generators"#96575jpdoyle wants to merge 1 commit intoNixOS:masterfrom
jpdoyle wants to merge 1 commit intoNixOS:masterfrom
Conversation
This reverts commit 72c8ed0.
Contributor
Author
^ This succeeded, so I'm willing to say that this revert fixes the issue. |
Contributor
|
Merge conflicts already? |
Member
|
Reverting is the last resort. In this case, it is likely also problematic (see #96479 (comment)). There was already some fixing up required to get where we are at now. |
Member
It seems I started some investigation, will comment in the original issue. |
Member
|
Closing in favor of #97008. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96479 (hopefully)
This reverts commit 72c8ed0.
Motivation for this change
unstableis blocked by #96479This is a quick hacky fix only -- there is clearly some strange interaction between
systemd-udevdandcryptsetupcaused by 72c8ed0.Things done
I'm currently running
However, my machine is taking a while with it as it is rebuilding systemd. I'll update this PR once it completes.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)