kimg: init at 0.3.0 #95890
Merged
kimg: init at 0.3.0 #95890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siraben
force-pushed
the
kimg-init
branch
2 times, most recently
from
48320f7 to
937d0f0
Compare
danieldk
suggested changes
Aug 21, 2020
ofborg
bot
added
8.has: package (new)
|
Applying suggestions causes the build to fail on darwin. |
|
Pushed another commit that addresses the suggestions, works on darwin. |
|
@GrahamcOfBorg build kimg |
|
I think it's ready to merge. |
doronbehar
reviewed
Aug 27, 2020
| sha256 = "00gj420m0jvhgm8kkslw8r69nl7r73bxrh6gqs2mx16ymcpkanpk"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ cmake asciidoc pkgconfig imagemagick7Big ]; |
There was a problem hiding this comment.
Sounds like imagemagick should go to regular buildInputs.
There was a problem hiding this comment.
It is used with asciidoc to generate the man pages, so it should be in nativeBuildInputs.
There was a problem hiding this comment.
Scratch that. I misremember, has been a week since I looked at the derivation. It does use imagemagick in the actual program, so this should indeed be in buildInputs.
danieldk
suggested changes
Aug 27, 2020
siraben
force-pushed
the
kimg-init
branch
2 times, most recently
from
17634c7 to
9fbe491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)