nixos/logrotate: switch paths option type from listOf to attrsOf#95809
Merged
aanderse merged 2 commits intoNixOS:masterfrom Aug 21, 2020
Merged
nixos/logrotate: switch paths option type from listOf to attrsOf#95809aanderse merged 2 commits intoNixOS:masterfrom
paths option type from listOf to attrsOf#95809aanderse merged 2 commits intoNixOS:masterfrom
Conversation
aanderse
force-pushed
the
logrotate
branch
3 times, most recently
from
381e3c8 to
62c1b13
Compare
ofborg
bot
added
6.topic: nixos
Member
Author
|
@infinisil we had a small conversation about this module and I always appreciate/enjoy your reviews... would you mind taking a look at this? |
infinisil
requested changes
Aug 21, 2020
Member
Author
|
Thanks for your review @infinisil. I have made a few fixes/additions as per your comments. I have also addressed some of the comments which I think might not be the best direction for this module. Please let me know your thoughts. |
infinisil
approved these changes
Aug 21, 2020
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
The first commit looks good now, but I can't really comment much on the second one as I don't know a lot about httpd. If you think the second one won't cause any problems then feel free to merge it :)
aanderse
changed the title
paths option type from listOf to attrsOf (submodule ...)paths option type from listOf to attrsOf
Member
Author
Contributor
|
This seems to have broken the nixos manual: https://hydra.nixos.org/build/125616472/nixlog/5 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#87702
It was a really bad idea for me to suggest @jslight90 to use a
listOfinstead ofattrsOffor thepathsoption. I upgraded a server tounstableand tried this out...attrsOfis a much better fit when given apriorityoption to control sort order.With this PR NixOS modules can actually start providing log rotation for (the very few) services that actually need it using
logrotate. The user remains in full control with the ability to even disable log rotation via theenableoption, like so:Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)