pandoc-plantuml-filter: init at 0.1.2#95143
Merged
jonringer merged 1 commit intoNixOS:masterfrom Aug 21, 2020
Merged
Conversation
c22a187 to
48fdb3d
Compare
Member
Author
|
I've tested this with: It creates a directory called Note that I'm not sure how to represent "peer" dependencies in Nix. |
jonringer
reviewed
Aug 11, 2020
pkgs/development/python-modules/pandoc-plantuml-filter/default.nix
Outdated
Show resolved
Hide resolved
Member
Author
|
I guess that makes this closer to a python application, not module since there's nothing to import. How to switch to that? |
jonringer
reviewed
Aug 14, 2020
pkgs/development/python-modules/pandoc-plantuml-filter/default.nix
Outdated
Show resolved
Hide resolved
4fb2940 to
efdfc4b
Compare
Member
Author
|
Put it next to |
Member
Author
jonringer
approved these changes
Aug 21, 2020
Contributor
jonringer
left a comment
There was a problem hiding this comment.
diff LGTM
https://github.com/NixOS/nixpkgs/pull/95143
1 package built:
pandoc-plantuml-filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds the Pandoc filter which converts PlantUML code blocks to PlantUML images. Pretty useful!
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)