Skip to content

pandoc-plantuml-filter: init at 0.1.2#95143

Merged
jonringer merged 1 commit intoNixOS:masterfrom
MatrixAI:pandoc-plantuml-filters
Aug 21, 2020
Merged

pandoc-plantuml-filter: init at 0.1.2#95143
jonringer merged 1 commit intoNixOS:masterfrom
MatrixAI:pandoc-plantuml-filters

Conversation

@CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Aug 11, 2020

Motivation for this change

Adds the Pandoc filter which converts PlantUML code blocks to PlantUML images. Pretty useful!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CMCDragonkai
Copy link
Member Author

CMCDragonkai commented Aug 11, 2020

I've tested this with:

pandoc -V geometry:margin=1in 'test.md' -o 'test.pdf' --filter pandoc-plantuml

It creates a directory called plantuml-images.

Note that plantuml has to be in the PATH to use this, but that's an expected thing since you need both pandoc and plantuml to use this filter.

I'm not sure how to represent "peer" dependencies in Nix.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 11, 2020
@CMCDragonkai
Copy link
Member Author

I guess that makes this closer to a python application, not module since there's nothing to import. How to switch to that?

@CMCDragonkai CMCDragonkai force-pushed the pandoc-plantuml-filters branch from 4fb2940 to efdfc4b Compare August 18, 2020 02:15
@CMCDragonkai
Copy link
Member Author

Put it next to pandoc-imagine. This is ready to be merged.

@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 18, 2020
@CMCDragonkai
Copy link
Member Author

@jonringer

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/95143
1 package built:
pandoc-plantuml-filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants