Conversation
|
Also, I don't see the gui being installed: |
|
@jonringer Are you commenting on the fact that there isn't an application binary among the outputs? QCSXCAD is a library so I believe this is correct. When I run AppCSXCAD (coming up in the next PR) the gui seems to run fine. If I misunderstood your comment, would you mind clarifying? Also worth mentioning that in addition to your suggested changes, I've updated to revision to be a more recent version. |
| enableParallelBuilding = true; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Qt-GUI for CSXCAD"; |
There was a problem hiding this comment.
the description says qt-gui for csxcad, but there's no gui, that's what I'm commenting on
There was a problem hiding this comment.
I copied this verbatim from the project's description, but I agree it's very misleading. I've changed this to "Qt library for CSXCAD". Better?
jonringer
left a comment
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 95100 1
Motivation for this change
Part of this pr. @jonringer
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)