Skip to content

modules-closure: don't ignore all deps if the first is builtin#95008

Closed
lheckemann wants to merge 1 commit intoNixOS:masterfrom
lheckemann:module-closure-fix
Closed

modules-closure: don't ignore all deps if the first is builtin#95008
lheckemann wants to merge 1 commit intoNixOS:masterfrom
lheckemann:module-closure-fix

Conversation

@lheckemann
Copy link
Member

@lheckemann lheckemann commented Aug 9, 2020

Motivation for this change

The previous version resulted in modules being omitted entirely
because the first dependency listed for them by modprobe was
built-in. Now, only the actual built-in modules will be ignored when
building the closure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

TODO: test if this fixes the issue for me in practice it does!

@ofborg test boot

The previous version resulted in modules being omitted entirely
because the first dependency listed for them by modprobe was
built-in. Now, only the actual built-in modules will be ignored when
building the closure.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 9, 2020
@xaverdh
Copy link
Contributor

xaverdh commented Aug 9, 2020

#92081 for prior art

@lheckemann
Copy link
Member Author

That's much better!

@lheckemann lheckemann closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants