Skip to content

nodePackages.ijavascript: init at 5.2.0#94945

Closed
costrouc wants to merge 1 commit intoNixOS:masterfrom
costrouc:ijavascript-kernel
Closed

nodePackages.ijavascript: init at 5.2.0#94945
costrouc wants to merge 1 commit intoNixOS:masterfrom
costrouc:ijavascript-kernel

Conversation

@costrouc
Copy link
Member

@costrouc costrouc commented Aug 8, 2020

Motivation for this change

Adding jupyter kernels in this case ijavascript kernel

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 8, 2020
@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2020

Result of nixpkgs-review pr 94945 1

1 package failed to build:
- joplin
11 packages built:
- lumo
- mastodon-bot
- postcss-cli
- redoc-cli
- vimPlugins.coc-git
- vimPlugins.coc-java
- vimPlugins.coc-prettier
- vimPlugins.coc-stylelint
- vimPlugins.coc-tsserver
- vimPlugins.coc-vetur
- wasm-text-gen

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 28, 2020

@costrouc Can you please separate the init and the regenerate command and fix the merge conflict?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 2, 2021

PR got combined with a few other node updates. Closing so that the update goes trough smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants