Skip to content

hyp2mat: init at 0.0.17#94765

Merged
ryantm merged 1 commit intoNixOS:masterfrom
matthuszagh:hyp2mat
Aug 6, 2020
Merged

hyp2mat: init at 0.0.17#94765
ryantm merged 1 commit intoNixOS:masterfrom
matthuszagh:hyp2mat

Conversation

@matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Aug 6, 2020 •
edited
Loading

Motivation for this change

Next part of a series of changes for this pr. @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 6, 2020
jonringer
jonringer reviewed Aug 6, 2020
View reviewed changes
@matthuszagh matthuszagh requested a review from jonringer August 6, 2020 03:58
ryantm
ryantm requested changes Aug 6, 2020
View reviewed changes
@matthuszagh matthuszagh requested a review from ryantm August 6, 2020 16:52
@ryantm ryantm merged commit be66239 into NixOS:master Aug 6, 2020
@matthuszagh matthuszagh deleted the hyp2mat branch August 6, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@ryantm ryantm Awaiting requested review from ryantm

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthuszagh @ryantm @jonringer