Skip to content

yubikey-agent: fix on darwin#93850

Merged
flokli merged 1 commit intoNixOS:masterfrom
philandstuff:fix-darwin-yubikey-agent
Jul 26, 2020
Merged

yubikey-agent: fix on darwin#93850
flokli merged 1 commit intoNixOS:masterfrom
philandstuff:fix-darwin-yubikey-agent

Conversation

@philandstuff
Copy link
Contributor

@philandstuff philandstuff commented Jul 25, 2020 •
edited
Loading

Motivation for this change

Mea culpa: in #92936, I did originally test on macOS but I forgot to
retest after adding the piv-go patch. Unfortunately, the piv-go patch
was broken on macOS. This pulls in the latest version of
go-piv/piv-go#75 which works on macOS now.

(This is a repeat of #93769 which went a bit wrong)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@philandstuff
yubikey-agent: fix on darwin
e01583a 
Mea culpa: in NixOS#92936, I did originally test on macOS but I forgot to
retest after adding the piv-go patch.  Unfortunately, the piv-go patch
was broken on macOS.  This pulls in the latest version of
go-piv/piv-go#75 which works on macOS now.
@philandstuff philandstuff requested review from flokli and rawkode July 25, 2020 21:24
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 25, 2020
@ofborg ofborg bot requested a review from kalbasit July 25, 2020 21:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 25, 2020
@vcunat vcunat mentioned this pull request Jul 26, 2020
Merged
10 tasks
@vcunat
Copy link
Member

vcunat commented Jul 26, 2020

Let the bot check the build.
@GrahamcOfBorg build yubikey-agent

@flokli flokli merged commit 12f4c3b into NixOS:master Jul 26, 2020
@philandstuff philandstuff deleted the fix-darwin-yubikey-agent branch July 26, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flokli flokli Awaiting requested review from flokli

@rawkode rawkode Awaiting requested review from rawkode

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philandstuff @vcunat @flokli