add github action to wait for ofborg

[Mic92]

In case ofborg is down this will not mark the CI as green.
Also if other github actions are used and pass
checks will be still marked as pending even if other other github
actions have passed.

[Mic92]

@GrahamcOfBorg build hello

[Mic92]

@GrahamcOfBorg build hello

[Mic92]

That commit still seems wrong...

[Mic92]

@GrahamcOfBorg build hello

[Mic92]

@GrahamcOfBorg eval

[zowoq]

Something that might be an issue with this approach is the limits on github actions, if ofborg goes down we'll start burning through our allocation.

[Mic92]

It is limited to 10min. How much time on github actions do we have?

[zowoq]

It is limited to 10min.

Which could end up adding up quickly if ofborg does down for any length of time.

[Mic92]

It is limited to 10min.

Which could end up adding up quickly if ofborg does down for any length of time.

Where do you have the information from that we have limits? This looks like there are only for private repos: https://docs.github.com/en/github/setting-up-and-managing-billing-and-payments-on-github/managing-your-spending-limit-for-github-actions#about-spending-limits-for-github-actions

[zowoq]

Where do you have the information from that we have limits? This looks like there are only for private repos:

Ah, must have misremembered. Concurrent jobs and API requests may be an issue?

https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits

[Mic92]

Not really. It would just means that the job is started later...

[Mic92]

Any idea why ofborg is not picking up this PR? Do I need to modify nix files?

[Mic92]

@GrahamcOfBorg eval

[Mic92]

@GrahamcOfBorg eval

[zowoq]

Any idea why ofborg is not picking up this PR? Do I need to modify nix files?

No. AFAIK, you shouldn't need to modify a nix file for it to start.

I have noticed that ofborg has been a bit flakey the last day or two, not picking up pushes or stopping after eval/meta checks and not triggering builds.

[flokli]

Let's keep the wip label as long as we flip the gnuhello tests, so we don't accidentially merge it ;-)

[Mic92]

This is working now. In case it timeouts its still clear that ofborg should have been run so users are not tricked into thinking that the CI run successfully.

[Mic92]

Let's see how this works out in practice.

[zowoq]

Builds started by an manual ofborg build *** satisfy this check, can we limit it to successful evals?

[Mic92]

Builds started by an manual ofborg build *** satisfy this check, can we limit it to successful evals?

It could check for a specific eval, but to be honest before we do this we rather should consider making the eval job a required check...

[zowoq]

It could check for a specific eval, but to be honest before we do this we rather should consider making the eval job a required check...

Should we disable the actions for now until we get the required checks working?

The timeout job is a nice workaround but I think the drawbacks may be outweighing the benefits of having it just for the editorconfig check.

[Mic92]

It could check for a specific eval, but to be honest before we do this we rather should consider making the eval job a required check...

Should we disable the actions for now until we get the required checks working?

The timeout job is a nice workaround but I think the drawbacks may be outweighing the benefits of having it just for the editorconfig check.

This is a problem with or without github actions. If someone triggers ofborg build it will mark the build as green. I don't see how this is worth than the status quo. In fact having github actions increases seeing the absence of ofborg runs. If ofborg is down for example github actions would still mark the build as failed. So just having the Waiting for ofborg action provides value on its own.

[zowoq]

In fact having github actions increases seeing the absence of ofborg runs. If ofborg is down for example github actions would still mark the build as failed. So just having the Waiting for ofborg action provides value on its own.

There was a 3hr wait for ofborg evals earlier, needed to clear a page of errored PRs after ofborg caught up.

[Mic92]

Let's continue discussion in #94658