appimage: switch to gst-plugins-base 1.0#93398
Merged
ryantm merged 1 commit intoNixOS:masterfrom Jul 21, 2020
Merged
Conversation
Flakebi
approved these changes
Jul 20, 2020
Member
|
Result of 19 packages built:- Sylk - appimage-run - deltachat-electron - devdocs-desktop - irccloud - joplin-desktop - ledger-live-desktop - marktext - minetime - notable - obsidian - runwayml - ssb-patchwork - standardnotes - station - tusk - unityhub - wootility - zulip |
1 similar comment
Contributor
|
Result of 19 packages built:- Sylk - appimage-run - deltachat-electron - devdocs-desktop - irccloud - joplin-desktop - ledger-live-desktop - marktext - minetime - notable - obsidian - runwayml - ssb-patchwork - standardnotes - station - tusk - unityhub - wootility - zulip |
thorstenweber83
approved these changes
Jul 20, 2020
jtojnar
reviewed
Aug 22, 2020
| @@ -163,7 +164,6 @@ rec { | |||
| SDL2_ttf | |||
| SDL2_mixer | |||
| gstreamer | |||
Member
There was a problem hiding this comment.
Same should be likely done with gstreamer.
jtojnar
added a commit
to jtojnar/nixpkgs
that referenced
this pull request
Sep 2, 2020
It is insecure and broken. Follow NixOS#93398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
gst-plugins-base0.10 is depricated and marked as broken as of d034a00.Not sure if we should delete GStreamer 0.10 as well, as version 1.0 is already in the package. (#39975)
fixes: #93174
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)