Skip to content

appimage: switch to gst-plugins-base 1.0#93398

Merged
ryantm merged 1 commit intoNixOS:masterfrom
IvarWithoutBones:appimage-run-fix
Jul 21, 2020
Merged

appimage: switch to gst-plugins-base 1.0#93398
ryantm merged 1 commit intoNixOS:masterfrom
IvarWithoutBones:appimage-run-fix

Conversation

@IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Jul 18, 2020

Motivation for this change

gst-plugins-base 0.10 is depricated and marked as broken as of d034a00.

Not sure if we should delete GStreamer 0.10 as well, as version 1.0 is already in the package. (#39975)

fixes: #93174

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
19 packages built:
     Sylk appimage-run deltachat-electron devdocs-desktop irccloud joplin-desktop ledger-live-desktop 
     marktext minetime notable obsidian runwayml ssb-patchwork standardnotes station tusk unityhub 
     wootility zulip
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 18, 2020
@Flakebi
Copy link
Member

Flakebi commented Jul 20, 2020

Result of nixpkgs-review pr 93398 1

19 packages built:
- Sylk
- appimage-run
- deltachat-electron
- devdocs-desktop
- irccloud
- joplin-desktop
- ledger-live-desktop
- marktext
- minetime
- notable
- obsidian
- runwayml
- ssb-patchwork
- standardnotes
- station
- tusk
- unityhub
- wootility
- zulip

1 similar comment
@thorstenweber83
Copy link
Contributor

Result of nixpkgs-review pr 93398 1

19 packages built:
- Sylk
- appimage-run
- deltachat-electron
- devdocs-desktop
- irccloud
- joplin-desktop
- ledger-live-desktop
- marktext
- minetime
- notable
- obsidian
- runwayml
- ssb-patchwork
- standardnotes
- station
- tusk
- unityhub
- wootility
- zulip

@afontaine afontaine mentioned this pull request Jul 21, 2020
10 tasks
@ryantm ryantm merged commit b78ffda into NixOS:master Jul 21, 2020
@IvarWithoutBones IvarWithoutBones deleted the appimage-run-fix branch July 21, 2020 15:35
@@ -163,7 +164,6 @@ rec {
SDL2_ttf
SDL2_mixer
gstreamer
Copy link
Member

@jtojnar jtojnar Aug 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same should be likely done with gstreamer.

jtojnar added a commit to jtojnar/nixpkgs that referenced this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

appimage-run: depends on broken gst-plugins-base

5 participants