eid-mw: 4.4.16 -> 4.4.27

[chvp]

Motivation for this change

Version bump.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[danieldk]

Why is this moving away from GitHub, since it seems to have this version?

https://github.com/Fedict/eid-mw/releases/tag/v4.4.27

Also, it already seems to have a newer release?

https://github.com/Fedict/eid-mw/releases/tag/v5.0.5

[chvp]

dist.eid.belgium.be/ is the official release channel, where the releases are also signed. It seemed more appropriate to me. The 5.x releases seem to be unstable releases: they aren't mentioned on https://eid.belgium.be/en and in https://dist.eid.belgium.be/continuous/sources they have a commit hash in the released tarballs. They also failed to build. The AUR also has the same version: https://aur.archlinux.org/packages/eid-mw/ (they also use the official release channel there).

[danieldk]

dist.eid.belgium.be/ is the official release channel, where the releases are also signed. It seemed more appropriate to me.

I see, thanks! For now it would probably be be better to continue using GitHub as an upstream until something like #43233 lands. Someone might forget to GPG-verify the source tarball on version bumps. Until then GitHub gives better accountability (easy to get diffs). For 4.4.27 it doesn't matter anyway, because the git tag is signed by one of the developers.

The 5.x releases seem to be unstable releases: they aren't mentioned on https://eid.belgium.be/en and in https://dist.eid.belgium.be/continuous/sources they have a commit hash in the released tarballs.

Ok, so then we should use 4.4.27.

[chvp]

Sure, I'll edit it later tonight.

[danieldk]

Thank you for contributing to nixpkgs 👍 . Could you change the src attribute to use fetchFromGitHub again? I also added another suggestion to replace a use of sed by substituteInPlace.

[danieldk]

For simple substitutions that do not rely on regular expressions, substituteInPlace is more canonical:

Suggested change

	sed -i "s%c_rehash%openssl rehash%g" plugins_tools/eid-viewer/Makefile.in
	substituteInPlace plugins_tools/eid-viewer/Makefile.in \
	--replace "c_rehash" "openssl rehash"

[danieldk]

LGTM. Thanks a lot!

Result of nixpkgs-review pr 92252 1

1 package built:

- eid-mw

Tested running the application in a sandbox: ✔️