Skip to content

pcloud: Init at 1.8.8#91182

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Patryk27:pcloud
Nov 25, 2020
Merged

pcloud: Init at 1.8.8#91182
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Patryk27:pcloud

Conversation

@Patryk27
Copy link
Member

Motivation for this change

Just a new application: pCloud.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 20, 2020
@frondeus
Copy link

Thank you kind sir for your work!

Downloaded, tested and finally pCloud works properly on my nixos laptop ❤️
I tested basic FUSE mounting (by looking at ~/pCloudDrive contents if I can read my cloud drive without allocating gigabytes of disk space), and classic sync capabilities.

I didn't test crypto or sharing tho.

Anyway - thanks.

@Patryk27
Copy link
Member Author

Patryk27 commented Jul 1, 2020

Just reminding; @Mic92 maybe?

@Patryk27
Copy link
Member Author

Ping, ping - maybe @worldofpeace? :-)

@Patryk27 Patryk27 changed the title pcloud: Init at 1.8.4 pcloud: Init at 1.8.8 Nov 1, 2020
@ryantm
Copy link
Member

ryantm commented Nov 1, 2020

Result of nixpkgs-review pr 91182 1

1 package built:
- pcloud

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 91182 run on x86_64-linux 1

1 package built:
  • pcloud

@SuperSandro2000 SuperSandro2000 merged commit 1dde9c5 into NixOS:master Nov 25, 2020
@Patryk27 Patryk27 deleted the pcloud branch November 25, 2020 21:54
Patryk27 added a commit to Patryk27/nixpkgs-committers that referenced this pull request Dec 28, 2025
Hi,

I'd like to nominate myself - I've been submitting pull requests since 2020, started by packaging [netris](NixOS/nixpkgs#85382) and then went on to improving [LXD](NixOS/nixpkgs#89540), [packaging](NixOS/nixpkgs#91182) and [maintaining](https://github.com/NixOS/nixpkgs/pulls?q=author%3APatryk27+pcloud) pCloud (which, amazingly enough, required fixing a bug in [patchelf](NixOS/patchelf#544) itself!), and overall I've been implementing various quality of live improvements [here](NixOS/nixpkgs#207466) and [there](NixOS/nixpkgs#354755).

I've given [a talk about my Nix-driven blog](https://www.youtube.com/watch?v=_7wqXN-7ebw&t=6695s) during NixCon 2024 in Berlin, so it's possible we've already met irl!

Outside of Nix, I'm the maintainer of Rust's [AVR backend](rust-lang/rust#131651), with commits and merging rights to [LLVM](https://github.com/llvm/llvm-project/pulls?q=author%3APatryk27) - just adding as an extra "in case it helps" mention 😇 

Couple of weeks ago I decided to shift my priorities from working on custom projects to helping the communities I'm a part of more - having committer access to nixpkgs would allow me to make a greater impact as I intend to focus on reviewing and merging both ongoing and stale pull requests, since it seems there's always not enough people willing to review stuff!

Thanks, Patryk :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants