Skip to content

thelounge: re-apply 'write out default path'#90069

Merged
flokli merged 1 commit intoNixOS:masterfrom
Mrmaxmeier:thelounge-restore-thelounge_home
Jun 10, 2020
Merged

thelounge: re-apply 'write out default path'#90069
flokli merged 1 commit intoNixOS:masterfrom
Mrmaxmeier:thelounge-restore-thelounge_home

Conversation

@Mrmaxmeier
Copy link
Contributor

@Mrmaxmeier Mrmaxmeier commented Jun 10, 2020

Re-apply
df2f8d9#diff-55e70513e1cc0032a186d6b7b367679aR128-R130

(cc #70318)

It seems like this got lost in #89184:

6602f87#diff-55e70513e1cc0032a186d6b7b367679aL126-L131

6602f87#diff-f7e3726c9a96ebbbffbb4e2ac12ba6d7R126-R128

With nice inline previews:

Before:

thelounge = nodePackages.thelounge.override {
buildInputs = [ nodePackages.node-pre-gyp ];
postInstall = ''
echo /var/lib/thelounge > $out/lib/node_modules/thelounge/.thelounge_home
'';
};

After:

thelounge = nodePackages.thelounge.override {
buildInputs = [ nodePackages.node-pre-gyp ];
};

Motivation for this change

My thelounge-instance died after upgrading to the latest nixos-unstable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 10, 2020
@flokli flokli merged commit 3947887 into NixOS:master Jun 10, 2020
@Mrmaxmeier Mrmaxmeier deleted the thelounge-restore-thelounge_home branch August 14, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants