Skip to content

clementine: 1.3.1 -> 1.4.0rc1, switch to Qt 5, fix build#89821

Merged
veprbl merged 2 commits intoNixOS:masterfrom
veprbl:pr/clementine_1_4_0rc1
Jun 13, 2020
Merged

clementine: 1.3.1 -> 1.4.0rc1, switch to Qt 5, fix build#89821
veprbl merged 2 commits intoNixOS:masterfrom
veprbl:pr/clementine_1_4_0rc1

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented Jun 8, 2020 •
edited
Loading

Motivation for this change

Fixes #89792
Step towards deprecating Qt 4 #33248
clementine 1.4.0rc1 is currently packaged in Arch Linux: https://www.archlinux.org/packages/community/x86_64/clementine/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukateras lukateras mentioned this pull request Jun 8, 2020
Closed
@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented Jun 8, 2020

@marius851000 Could you, please, test this?

@veprbl veprbl mentioned this pull request Jun 8, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from Phreedom and ttuegel June 8, 2020 17:29
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 8, 2020
@veprbl veprbl merged commit f97f334 into NixOS:master Jun 13, 2020
@veprbl veprbl deleted the pr/clementine_1_4_0rc1 branch June 13, 2020 23:54
@marius851000
Copy link
Copy Markdown
Contributor

marius851000 commented Jun 14, 2020

Sorry for being late. I confirm this new version work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clementine stopped functioning

2 participants

@veprbl @marius851000