Conversation
lblasc
approved these changes
Jun 7, 2020
LnL7
reviewed
Jun 7, 2020
Member
LnL7
left a comment
There was a problem hiding this comment.
Too many other things failed on staging so can't test it properly as is.
Member
|
cannot test any cargo-based build on aarch64 because one git test fail on our community aarch64 builder. rustc builds itself. |
Member
|
Reminder for testing this PR. |
Member
|
I will give aarch64 another try. |
Member
|
aarch64 builds now fd properly. |
10 tasks
Member
|
This should be updated to 1.44.1 IMO. Apparently 1.44.0 had several regressions: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1441-2020-06-18 |
Nothing seems to need this to build any more.
Member
Author
|
This should be updated to 1.44.1 IMO. Apparently 1.44.0 had several
regressions:
https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1441-2020-06-18
Done.
Thunderbird and Firefox are now broken due to #85189, but I think it's
reasonable to assume that if they built with 1.44.0 they'll build with
1.44.1.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn’t able to build thunderbird and Firefox for unrelated reasons (unless it’s gone away on a more recent staging I’ll open a PR for that shortly), but with those issues addressed I’ve successfully built Firefox and Thunderbird with Rust 1.44, so they shouldn’t block the rust update.
Could a Darwin user please
nix-build -A fdfor me please?Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)