Skip to content

rustc: 1.43.0 -> 1.44.1#89576

Merged
FRidh merged 2 commits intoNixOS:stagingfrom
alyssais:rust
Jul 2, 2020
Merged

rustc: 1.43.0 -> 1.44.1#89576
FRidh merged 2 commits intoNixOS:stagingfrom
alyssais:rust

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Jun 6, 2020

I wasn’t able to build thunderbird and Firefox for unrelated reasons (unless it’s gone away on a more recent staging I’ll open a PR for that shortly), but with those issues addressed I’ve successfully built Firefox and Thunderbird with Rust 1.44, so they shouldn’t block the rust update.

Could a Darwin user please nix-build -A fd for me please?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested review from LnL7 and Mic92 as code owners June 6, 2020 01:09
@ofborg ofborg bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 6, 2020
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many other things failed on staging so can't test it properly as is.

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2020

cannot test any cargo-based build on aarch64 because one git test fail on our community aarch64 builder. rustc builds itself.

@FRidh FRidh added this to the 20.09 milestone Jun 19, 2020
@FRidh
Copy link
Member

FRidh commented Jun 19, 2020

Reminder for testing this PR.

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this while investigating #89481, LGTM 👍

@Mic92
Copy link
Member

Mic92 commented Jun 21, 2020

I will give aarch64 another try.

@Mic92
Copy link
Member

Mic92 commented Jun 22, 2020

aarch64 builds now fd properly.

@marsam marsam mentioned this pull request Jun 23, 2020
10 tasks
@L-as
Copy link
Member

L-as commented Jun 27, 2020

This should be updated to 1.44.1 IMO. Apparently 1.44.0 had several regressions: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1441-2020-06-18

alyssais added 2 commits June 29, 2020 17:31
Nothing seems to need this to build any more.
@alyssais
Copy link
Member Author

alyssais commented Jun 30, 2020 via email

@FRidh FRidh changed the title rustc: 1.43.0 -> 1.44.0 rustc: 1.43.0 -> 1.44.1 Jul 2, 2020
@FRidh FRidh merged commit 204d583 into NixOS:staging Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants