treewide: jdk: make it point to latest version#88714
Closed
doronbehar wants to merge 1 commit intoNixOS:masterfrom
Closed
treewide: jdk: make it point to latest version#88714doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar wants to merge 1 commit intoNixOS:masterfrom
Conversation
wamserma
approved these changes
May 24, 2020
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Contributor
Author
|
I'm thinking that perhaps, it'll be better to make |
Make every other derivation, use jdk8 explicitly, so attributes won't appear as changed by ofborg.
Contributor
Author
|
Closed in favor of #89731 . |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I want to encourage contributors to use (or at least try to use) the latest openjdk when they add new derivations that need Java. This change strives to make
jdkpoint to the latestjdk, while every other derivation that usesjdkwithout an explicit version suffix, now usesjdk8explicitly.I'm still waiting for ofborg to tag this PR as "10.rebuild-linux: 0", that's why it's a draft.
See also https://discourse.nixos.org/t/nixpkgs-policy-regarding-libraries-available-in-multiple-versions/7026 .
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)