sway-contrib: init with grimshot and inactive-windows-transparency#88577
Merged
Ma27 merged 2 commits intoNixOS:masterfrom Jun 14, 2020
Merged
sway-contrib: init with grimshot and inactive-windows-transparency#88577Ma27 merged 2 commits intoNixOS:masterfrom
Ma27 merged 2 commits intoNixOS:masterfrom
Conversation
ofborg
bot
added
8.has: package (new)
primeos
suggested changes
Jun 5, 2020
Member
primeos
left a comment
primeos
left a comment
There was a problem hiding this comment.
I added a few TODOs.
Regarding #87979 (comment): Yes, unfortunately (in this case) mentioning an issue in a PR doesn't generate any notifications.
evils
force-pushed
the
sway-contrib
branch
4 times, most recently
from
601bd14 to
491bd89
Compare
Mic92
reviewed
Jun 8, 2020
Mic92
reviewed
Jun 8, 2020
Mic92
reviewed
Jun 8, 2020
Mic92
reviewed
Jun 8, 2020
Member
Mic92
left a comment
Mic92
left a comment
There was a problem hiding this comment.
Untested but looks good to me if those last issues are fixed.
evils
force-pushed
the
sway-contrib
branch
2 times, most recently
from
52a2191 to
d904f54
Compare
Member
Author
|
i think this is ready to merge |
Ma27
approved these changes
Jun 10, 2020
Member
Ma27
left a comment
Ma27
left a comment
There was a problem hiding this comment.
Thanks! Successfully tested this locally.
I left two minor comments, but those are definitely not supposed to keep this PR from getting merged :)
at sway-unwrapped.version
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
no one appears to be against to the solution reached in #87979
closes #87831
Things done
add package set
pkgs.sway-contribcontainingsway-contrib.grimshot, a screenshot utilitywith an alias for
pkgs.grimshotas this is a fairly fleshed out toolsway-contrib.inactive-windows-transparency, a script that makes inactive windows transparentsandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)/nix/store/ra8b9q1ihdnp04595ahdl6iczg08drgm-grimshot-2020-05-08 101551232/nix/store/hd48r6ss5lpvgqch663z1alnbf6s4p72-python3.7-sway-inactive-windows-transparency-1.4 107722384Notes
grimshotmay get a rotated screen wrong due to bugs in dependencies that have been fixed upstreaminactive-windows-transparencyleaves the last active window on a secondary screen active swaywm/sway#5372