Skip to content

nodePackages.@nestjs/cli: init at 7.2.0#87918

Merged
alyssais merged 1 commit intoNixOS:masterfrom
leungbk:nestjs
Jun 19, 2020
Merged

nodePackages.@nestjs/cli: init at 7.2.0#87918
alyssais merged 1 commit intoNixOS:masterfrom
leungbk:nestjs

Conversation

@leungbk
Copy link
Member

@leungbk leungbk commented May 16, 2020 •
edited
Loading

Motivation for this change

Add nestjs/cli, a NPM package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 16, 2020
@leungbk leungbk changed the title nodePackages_10_x.@nestjs/cli: init at 7.0.13 nodePackages.@nestjs/cli: init at 7.0.13 May 17, 2020
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after merging #89184

@prusnak prusnak added 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels May 30, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels May 30, 2020
@leungbk
Copy link
Member Author

leungbk commented May 30, 2020

@prusnak OK, I resolved the merge conflict.

@leungbk leungbk changed the title nodePackages.@nestjs/cli: init at 7.0.13 nodePackages.@nestjs/cli: init at 7.2.0 May 30, 2020
@ofborg ofborg bot removed the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Jun 3, 2020
@leungbk
Copy link
Member Author

leungbk commented Jun 3, 2020

@prusnak I've resolved the merge conflict again. If there are any obstacles to this getting merged, please let me know.

@leungbk
Copy link
Member Author

leungbk commented Jun 9, 2020

@prusnak

@leungbk leungbk requested a review from prusnak June 9, 2020 05:36
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 9, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 19, 2020
@ofborg ofborg bot removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 19, 2020
@leungbk
Copy link
Member Author

leungbk commented Jun 19, 2020

@prusnak

@prusnak
Copy link
Member

prusnak commented Jun 19, 2020

@leungbk I don't have merge permissions for this repo. Your PR needs to be merged by someone who has them.

@alyssais alyssais merged commit 36572ae into NixOS:master Jun 19, 2020
@leungbk leungbk deleted the nestjs branch September 5, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prusnak prusnak Awaiting requested review from prusnak

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leungbk @prusnak @alyssais