nodePackages: init he and escape-string-regexp

[expipiplus1]

These are a prerequisite for building the Vulkan
documentation. Vulkan-Docs
doesn't come with a well-formed package.json which makes it difficult to
use with node2nix or other tools. Having these packages here makes it
very easy.

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[prusnak]

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

[expipiplus1]

@prusnak I have rebased on master.

[prusnak]

Does this come from node2nix? As per RFC45 the URLs should be quoted:

Suggested change

	homepage = https://mths.be/he;
	homepage = "https://mths.be/he";

[expipiplus1]

done, thanks

[expipiplus1]

Is it possible to get this merged, please?

[veprbl]

Landed as 74ff4f6 and d6c0115

[expipiplus1]

Thanks!

…

On Thu, Jun 11, 2020, 8:19 AM Dmitry Kalinkin ***@***.***> wrote: Landed as 74ff4f6 <74ff4f6> and d6c0115 <d6c0115> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86773 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRJXGGNKKMVAFMLTJNSJLRWAPHNANCNFSM4MYXXJOA> .