Skip to content

[20.03] haskellPackages.ghcide: Fix build#86659

Merged
cdepillabout merged 1 commit intoNixOS:release-20.03from
maralorn:fix-ghcide
May 4, 2020
Merged

[20.03] haskellPackages.ghcide: Fix build#86659
cdepillabout merged 1 commit intoNixOS:release-20.03from
maralorn:fix-ghcide

Conversation

@maralorn
Copy link
Member

@maralorn maralorn commented May 3, 2020

Motivation for this change

ghcide is marked as broken and is not building. With these changes it builds.

Please let me know if I should structure the overrides in a different way.
When this PR is approved I will port it to the haskell-updates branch. But first I wanna know if I did this right.
I am especially confused by the recursive library overrides. It‘s not pretty this way. e.g. the override for regex-tdfa_1_3_1_0 which needs a pinned regex-base version is now twice in the file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@maralorn maralorn changed the title haskellPackages.ghcide: Fix build [20.03] haskellPackages.ghcide: Fix build May 3, 2020
@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 3, 2020
@cdepillabout
Copy link
Member

cdepillabout commented May 4, 2020

@maralorn Thanks for working on this. I think a lot of Haskellers have been trying out ghcide. It'd be nice if people could just get it from nixpkgs.

@maralorn
Copy link
Member Author

maralorn commented May 4, 2020

@cdepillabout I do believe I have now fixed all your concerns and all my concerns.

  • Moved the lsp stuff to hackage-packages and put that in the yaml, so that it doesn‘t get lost.
  • Activated hydra builds.
  • figured out the use of self, so that I need to do less overrides on my own.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 4, 2020
@maralorn maralorn requested a review from cdepillabout May 4, 2020 09:35
@cdepillabout
Copy link
Member

cdepillabout commented May 4, 2020

@maralorn

One more change and this can be merged in:

haddock-library_1_8_0 needs to have the hydraPlatforms = stdenv.lib.platforms.none line removed.

Once that is done, I will merge this in. I have confirmed that ghcide was able to build.

@cdepillabout cdepillabout merged commit 410cf9e into NixOS:release-20.03 May 4, 2020
@maralorn maralorn deleted the fix-ghcide branch May 4, 2020 13:15
maralorn added a commit to maralorn/nixpkgs that referenced this pull request May 4, 2020
This is the haskell-updates version of NixOS#86659
peti pushed a commit that referenced this pull request May 5, 2020
This is the haskell-updates version of #86659
peti pushed a commit that referenced this pull request May 8, 2020
This is the haskell-updates version of #86659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants