gnomeExtensions.gtile: init at 34

[firmero]

Motivation for this change

A window tiling extension for Gnome.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[pbogdan]

LGTM, only remaining suggestion I have would be to re-order the commits so that the maintainers entry is created first.

Other than that I'll defer to @worldofpeace and @jtojnar our resident GNOME gurus (who hopefully don't mind me to summoning them directly).

[jtojnar]

Do the schemas installed to the extension directory as done on the first line not work?

[firmero]

They work in the way that i can see extension settings from Extensions app but cannot see them if I run dconf-editor. If i copy schemas to schemadir and add extension package to services.xserver.desktopManager.gnome3.sessionPath list, then it works (that schemadir is appended in variable XDG_DATA_DIR).

[jtojnar]

Yeah, I do not think the schemas of extensions are expected to be seen in dconf editor. And I am still not sure if dconf-editor is even compatible with Nix (since it relies on global data like sessionPath).

[firmero]

From description of sessionPath option:

Additional list of packages to be added to the session search path. Useful for GNOME Shell extensions or GSettings-conditional autostart. Note that this should be a last resort; patching the package is preferred (see GPaste).

I've took a look at gpaste and been inspirited with usage of glib.makeSchemaPath.

[firmero]

My motivation was to get option names using dconf-editor, without looking at the xml schema of extension.

[jtojnar]

When overriding installPhase, you should also provide runHook preInstall and runHook postInstall. Though, in this case, it is better to rely on the default installPhase.

[firmero]

I just used the same approach which is used is another extensions within gnome-3 extensions directory. In general, i think that nix files in that directory should be refactored, to look consistent.

[jtojnar]

Does not seem to be used.

[firmero]

yeah, is see, glib is used only in ${glib.makeSchemaPath} expression and there is no internal usage of glib (e.g. glib-compile-schemas usage while Makefile target producing).

[stale]

I marked this as stale due to inactivity. → More info

[SuperSandro2000]

Suggested change

	meta = with stdenv.lib; {
	meta = with lib; {

[piegamesde]

Thank you for your work! However, the extension has already been packaged as of #118232, making this PR obsolete.