Conversation
pkgs/tools/misc/tmux/default.nix
Outdated
| version = "3.1"; | ||
|
|
||
| outputs = [ "out" "man" ]; | ||
| outputs = [ "out" ]; |
There was a problem hiding this comment.
I think this line is redundant if you only want to have the "out" output.
There was a problem hiding this comment.
I dom't believe removing the man output is the solution.
I am not sure how nix-shell and MANPATH interact
nix-shell --pure -p tmux.man man does not find the man but my installed tmux brings up the manpage
There was a problem hiding this comment.
I think this line is redundant if you only want to have the
"out"output.
Oh yes, I agree. I'll change this in a second.
There was a problem hiding this comment.
I dom't believe removing the man output is the solution.
I am not sure how nix-shell and MANPATH interact
nix-shell --pure -p tmux.man mandoes not find the man but my installed tmux brings up the manpage
Okay, weird, it doesn't work for me. But it's not terribly important. I'll await further guidance how to proceed. :-) Thank you two of your review!
|
👎 the multiple-output feature exists for a reason: https://nixos.org/nixpkgs/manual/#chap-multiple-output I'm not 100% sure why the MANPATH isn't properly configured on
Is it possible that |
|
This should be closed in favor of either of: |
|
Thank you @doronbehar, I agree this should be closed in favor of the other issues/pull requests. I did not notice these before. Thank you for your work on our documentation system! |
Motivation for this change
On current master,
man tmuxcomes empty after in anix-shell -p tmux. This pull request fixes that.However, I'm a little bit unsure whether this is the correct procedure. I looked at other packages for guidance, but didn't spot a consistent pattern. The packages
fehandvdrboth use multiple outputs, astmuxdid before this pull request; the manpages forfehare installed correctly and these forvdrare not.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)